geoffreyclaude commented on code in PR #23012:
URL: https://github.com/apache/datafusion/pull/23012#discussion_r3470397305
##########
datafusion/physical-expr/src/expressions/in_list/primitive_filter.rs:
##########
@@ -104,6 +104,81 @@ impl StaticFilter for UInt8BitmapFilter {
}
}
+/// Bitmap filter for O(1) `UInt16` set membership via single bit test.
+///
+/// `UInt16` has 65,536 possible values, so the filter stores membership in an
Review Comment:
Actually the branchless strategy (see later PR in the stack) wins against
bitmaps on lists of sizes up to 8 (both for u8 and u16.)
I still need to amend it though, as it currently skips 1 and 2 byte types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
