alamb commented on code in PR #23012:
URL: https://github.com/apache/datafusion/pull/23012#discussion_r3470348532
##########
datafusion/physical-expr/src/expressions/in_list/primitive_filter.rs:
##########
@@ -104,6 +104,81 @@ impl StaticFilter for UInt8BitmapFilter {
}
}
+/// Bitmap filter for O(1) `UInt16` set membership via single bit test.
+///
+/// `UInt16` has 65,536 possible values, so the filter stores membership in an
Review Comment:
the only question I have is is it worth 8KB for a small inlist -- e.g. if
there are 3 elements, 8kb may be a lot of memory overhead, though perhaps the
performance is worth it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
