2010YOUY01 commented on PR #23140: URL: https://github.com/apache/datafusion/pull/23140#issuecomment-4786845454
> Thank you for opening this pull request! > > Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). > > Details It suggests to use `#[non_exhaustive]` ``` // library crate #[non_exhaustive] pub enum Color { Red, Green, } ``` Then downstream crate must include wildcard `_` and later adding new enum variant won't be counted as a breaking change. ``` match color { Color::Red => "red", Color::Green => "green", _ => "unknown future color", } ``` I think it's better to keep it as a breaking change and require downstreams to update. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
