github-actions[bot] commented on PR #23140: URL: https://github.com/apache/datafusion/pull/23140#issuecomment-4785516141
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion-ffi v54.0.0 (current) Built [ 64.037s] (current) Parsing datafusion-ffi v54.0.0 (current) Parsed [ 0.065s] (current) Building datafusion-ffi v54.0.0 (baseline) Built [ 58.659s] (baseline) Parsing datafusion-ffi v54.0.0 (baseline) Parsed [ 0.065s] (baseline) Checking datafusion-ffi v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.369s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 125.086s] datafusion-ffi Building datafusion-physical-expr-common v54.0.0 (current) Built [ 23.003s] (current) Parsing datafusion-physical-expr-common v54.0.0 (current) Parsed [ 0.023s] (current) Building datafusion-physical-expr-common v54.0.0 (baseline) Built [ 23.392s] (baseline) Parsing datafusion-physical-expr-common v54.0.0 (baseline) Parsed [ 0.023s] (baseline) Checking datafusion-physical-expr-common v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.302s] 223 checks: 222 pass, 1 fail, 0 warn, 30 skip --- failure enum_variant_added: enum variant added on exhaustive enum --- Description: A publicly-visible enum without #[non_exhaustive] has a new variant. ref: https://doc.rust-lang.org/cargo/reference/semver.html#enum-variant-new impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/enum_variant_added.ron Failed in: variant MetricValue:PeakMemoryUsage in /home/runner/work/datafusion/datafusion/datafusion/physical-expr-common/src/metrics/value.rs:676 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 47.535s] datafusion-physical-expr-common Building datafusion-physical-plan v54.0.0 (current) Built [ 35.290s] (current) Parsing datafusion-physical-plan v54.0.0 (current) Parsed [ 0.138s] (current) Building datafusion-physical-plan v54.0.0 (baseline) Built [ 34.832s] (baseline) Parsing datafusion-physical-plan v54.0.0 (baseline) Parsed [ 0.140s] (baseline) Checking datafusion-physical-plan v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.890s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 72.563s] datafusion-physical-plan Building datafusion-sqllogictest v54.0.0 (current) Built [ 186.647s] (current) Parsing datafusion-sqllogictest v54.0.0 (current) Parsed [ 0.024s] (current) Building datafusion-sqllogictest v54.0.0 (baseline) Built [ 182.692s] (baseline) Parsing datafusion-sqllogictest v54.0.0 (baseline) Parsed [ 0.024s] (baseline) Checking datafusion-sqllogictest v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.118s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 372.122s] datafusion-sqllogictest ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
