kumarUjjawal commented on PR #23091: URL: https://github.com/apache/datafusion/pull/23091#issuecomment-4775949269
> Nice cleanup. I'm wondering if `TopKHeapBoundary` should hold both the heap row and the batch it points to, instead of having `threshold_values` take `&TopKHeap` and look back into `heap.store`. > > That would make it clearer that the sort-key bytes, scalar values, and prefix row all come from the same row. Thank you @geoffreyclaude for the feedback! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
