2010YOUY01 commented on code in PR #11787:
URL: https://github.com/apache/datafusion/pull/11787#discussion_r1702749281
##########
datafusion/expr/src/type_coercion/functions.rs:
##########
@@ -573,6 +573,8 @@ fn coerced_from<'a>(
(Interval(_), _) if matches!(type_from, Utf8 | LargeUtf8) => {
Some(type_into.clone())
}
+ // We can go into a Utf8View from a Utf8 or LargeUtf8
+ (Utf8View, _) if matches!(type_from, Utf8 | LargeUtf8) =>
Some(type_into.clone()),
Review Comment:
I see, the semantics is < 32 bit length `LargeUtf8` conversion is supported,
otherwise, some runtime error will occur. This makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
