alamb commented on code in PR #11787:
URL: https://github.com/apache/datafusion/pull/11787#discussion_r1702674805
##########
datafusion/functions/src/string/starts_with.rs:
##########
@@ -81,18 +106,73 @@ impl ScalarUDFImpl for StartsWithFunc {
}
fn return_type(&self, _arg_types: &[DataType]) -> Result<DataType> {
- use DataType::*;
-
- Ok(Boolean)
+ Ok(DataType::Boolean)
}
fn invoke(&self, args: &[ColumnarValue]) -> Result<ColumnarValue> {
match args[0].data_type() {
DataType::Utf8 => make_scalar_function(starts_with::<i32>,
vec![])(args),
- DataType::LargeUtf8 => {
- return make_scalar_function(starts_with::<i64>, vec![])(args);
- }
- _ => internal_err!("Unsupported data type"),
+ DataType::LargeUtf8 => make_scalar_function(starts_with::<i64>,
vec![])(args),
+ DataType::Utf8View => make_scalar_function(starts_with::<i32>,
vec![])(args),
+ _ => internal_err!("Unsupported data types for starts_with")?,
}
}
}
+
+#[cfg(test)]
+mod tests {
+ use crate::utils::test::test_function;
+ use arrow::array::{Array, BooleanArray};
+ use arrow::datatypes::DataType::Boolean;
+ use datafusion_common::{Result, ScalarValue};
+ use datafusion_expr::{ColumnarValue, ScalarUDFImpl};
+
+ use super::*;
+
+ #[test]
+ fn test_functions() -> Result<()> {
+ // Generate test cases for starts_with
+ let test_cases = vec![
Review Comment:
Sounds good -- thank you. What I have found works well in the past is to do
like 10 at a time (if you make more than that the number of parallel threads /
work I found overwhelmed our ability to review them)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
