mbutrovich commented on issue #21080: URL: https://github.com/apache/datafusion/issues/21080#issuecomment-4633642413
Comet is seeing performance regressions for TPC-H and TPC-DS SF1000. > Benchmarked SF1000 TPC-H and TPC-DS: > > <img alt="Image" width="1000" height="600" src="https://private-user-images.githubusercontent.com/6855576/603578892-915ba18c-4085-4df6-ac9b-a8614775795e.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3ODA2NzgzNDksIm5iZiI6MTc4MDY3ODA0OSwicGF0aCI6Ii82ODU1NTc2LzYwMzU3ODg5Mi05MTViYTE4Yy00MDg1LTRkZjYtYWM5Yi1hODYxNDc3NTc5NWUucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI2MDYwNSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNjA2MDVUMTY0NzI5WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NDQyNTMwNTFhZTEyOTMxYWIyMzg4ZGJjMDM1ZTJiNjVlNTNkYTI4ZWRkMzI3ZDVmOTllYzkzZmNkNTA5NmIxMyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmcmVzcG9uc2UtY29udGVudC10eXBlPWltYWdlJTJGcG5nIn0.U8jykOU1_qtWTI0pLfp9Pm5ytqmE0i-PlsGBQ7c99YQ"> <img alt="Image" width="2000" height="343" src="https://private-user-images.githubusercontent.com/6855576/603578894-5aa48 a23-62fd-4126-8432-75ed580a8ced.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3ODA2NzgzNDksIm5iZiI6MTc4MDY3ODA0OSwicGF0aCI6Ii82ODU1NTc2LzYwMzU3ODg5NC01YWE0OGEyMy02MmZkLTQxMjYtODQzMi03NWVkNTgwYThjZWQucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI2MDYwNSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNjA2MDVUMTY0NzI5WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NzVlY2Q0ZDY3ZGU0NGZmNGVjNGFkNzIwNmFlYzJiMmI4YmQ4ZjJmZTAxMGE4ZmUyOTlkMGY1YjE4ZjEzZjBiNiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmcmVzcG9uc2UtY29udGVudC10eXBlPWltYWdlJTJGcG5nIn0.NqW7ezoHIxP8rlpj17wBgSJ2_iaZ9IJ3WSkdLTdplQI"> <img alt="Image" width="1000" height="600" src="https://private-user-images.githubusercontent.com/6855576/603578895-5bb017fa-f7af-4613-87ec-8ecb91887b19.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1 YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3ODA2NzgzNDksIm5iZiI6MTc4MDY3ODA0OSwicGF0aCI6Ii82ODU1NTc2LzYwMzU3ODg5NS01YmIwMTdmYS1mN2FmLTQ2MTMtODdlYy04ZWNiOTE4ODdiMTkucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI2MDYwNSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNjA2MDVUMTY0NzI5WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9OGEyYzUxODUyYTY1ZGUwZDVmYzhlMzZmMmM0MzdmZTZiYjU0NjRhZDI4MjE5ZmQ5YTdhMjhiYzAwMGUyZDhkZSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmcmVzcG9uc2UtY29udGVudC10eXBlPWltYWdlJTJGcG5nIn0.J1hlGUlGRYnrY3_rXe15BDF3eY-Ag8hoPY_Cxa8UmO4"> <img alt="Image" width="1500" height="600" src="https://private-user-images.githubusercontent.com/6855576/603578893-1535d932-88ff-45c3-a8d8-ef6a10e85665.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3ODA2NzgzNDksIm5iZiI6MTc4MDY3ODA0OSwicGF0aCI6Ii82ODU1NTc2LzYwMzU3ODg5My0xN TM1ZDkzMi04OGZmLTQ1YzMtYThkOC1lZjZhMTBlODU2NjUucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI2MDYwNSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNjA2MDVUMTY0NzI5WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZWZkZDAyN2YzYzEwNDNmZGQ4OTk0MDg1YjBhMzM3ZjFkMzk4MTMxMzY0MGU2MzliODVlMDY1MmI1NDlhZTViNyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmcmVzcG9uc2UtY29udGVudC10eXBlPWltYWdlJTJGcG5nIn0.i-59et6KQoTEmSMLU9WkIdl_-HTjU5ogdOIEFVgD6kM"> > I'm digging into the regressions, but the hash joins jump out at me immediately as slower. > > main: > > <img alt="Image" width="1787" height="306" src="https://private-user-images.githubusercontent.com/6855576/603579086-3ab00a03-bd63-428e-bf44-965fbebb1404.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3ODA2NzgzNDksIm5iZiI6MTc4MDY3ODA0OSwicGF0aCI6Ii82ODU1NTc2LzYwMzU3OTA4Ni0zYWIwMGEwMy1iZDYzLTQyOGUtYmY0NC05NjVmYmViYjE0MDQucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI2MDYwNSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNjA2MDVUMTY0NzI5WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YTJjZDRkOWQ4Y2JhNmIzNTA5ZDkyYzdmNmQ3ZDUzNzBiMjAxOTE3MzUxMzdjNDJmYjEwNDdjMmFjMzU0OGZiZSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmcmVzcG9uc2UtY29udGVudC10eXBlPWltYWdlJTJGcG5nIn0.C_QP0Xgn3UzbrsGPTn0751wxw5kNwqqhCGdJ6kCRZuc"> > DF54: > > <img alt="Image" width="1826" height="330" src="https://private-user-images.githubusercontent.com/6855576/603579237-af219f6e-79a0-41fa-841b-f95bf7cb528e.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3ODA2NzgzNDksIm5iZiI6MTc4MDY3ODA0OSwicGF0aCI6Ii82ODU1NTc2LzYwMzU3OTIzNy1hZjIxOWY2ZS03OWEwLTQxZmEtODQxYi1mOTViZjdjYjUyOGUucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI2MDYwNSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNjA2MDVUMTY0NzI5WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YTI5NzYyZGI2N2NkOWIyZDc4YzlkZWZjZDRmYzk4MzNhY2U3NWViNTBkZmI3MTQxOTNjOWZkYjczNmU1NjBmYSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmcmVzcG9uc2UtY29udGVudC10eXBlPWltYWdlJTJGcG5nIn0.eT6Dtor1lp2JoC9Lyke96CXm0iyfQTlB6WpIjbBiorY"> I will try to reproduce in DataFusion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
