kumarUjjawal commented on PR #22764: URL: https://github.com/apache/datafusion/pull/22764#issuecomment-4628757897
the correlation accumulator internally uses two standard-deviation trackers, and their row-removal logic has the same divide-by-zero-into-NaN problem: https://github.com/apache/datafusion/blob/71b5da1e747fa25d30ef49424d92001bdfd1d573/datafusion/functions-aggregate/src/variance.rs#L351-L353 `corr` would still return NaN through this path. The same reset-on-empty fix is needed here too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
