andygrove commented on PR #4592: URL: https://github.com/apache/datafusion-comet/pull/4592#issuecomment-4626225356
Thanks @michaelmitchell-bit. This looks good overall. StringSplitSQL is collation-aware in Spark and Comet does not support different collations yet, so it would be good to add a fallback for that case. See `concat` and `reverse` for examples. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
