alamb commented on code in PR #22744:
URL: https://github.com/apache/datafusion/pull/22744#discussion_r3357492458
##########
datafusion-cli/src/main.rs:
##########
@@ -613,9 +613,9 @@ mod tests {
+-----------------------------------+-----------------+---------------------+------+------------------+
| filename | file_size_bytes |
metadata_size_bytes | hits | extra |
+-----------------------------------+-----------------+---------------------+------+------------------+
- | alltypes_plain.parquet | 1851 | 8882
| 2 | page_index=false |
- | alltypes_tiny_pages.parquet | 454233 | 269074
| 2 | page_index=true |
- | lz4_raw_compressed_larger.parquet | 380836 | 1339
| 2 | page_index=false |
+ | alltypes_plain.parquet | 1851 | 8794
| 2 | page_index=false |
Review Comment:
I think this changed (smaller in memory size) due to the representation
change of `CompressionCodec` in this pr
- https://github.com/apache/arrow-rs/pull/9864
It changes from `Compression` which also carries the compression level:
ZSTD(ZstdLevel), GZIP(GzipLevel), BROTLI(BrotliLevel) — and ZstdLevel(i32) /
GzipLevel(u32) / BrotliLevel(u32) and are 4-byte wrappers. So Compression =
4-byte discriminant + 4-byte level = 8 bytes.
To a fieldless enum `CompressionCodec` -- 1 byte
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
