alamb commented on code in PR #22744:
URL: https://github.com/apache/datafusion/pull/22744#discussion_r3352068733
##########
datafusion/common/src/file_options/mod.rs:
##########
@@ -114,14 +114,14 @@ mod tests {
properties
.bloom_filter_properties(&ColumnPath::from(""))
.expect("expected bloom properties!")
- .fpp,
+ .fpp(),
Review Comment:
These fields are made private in
- https://github.com/apache/arrow-rs/pull/9969
##########
datafusion/common/src/file_options/parquet_writer.rs:
##########
@@ -235,7 +235,7 @@ impl ParquetOptions {
builder = builder.set_bloom_filter_fpp(*bloom_filter_fpp);
};
if let Some(bloom_filter_ndv) = bloom_filter_ndv {
- builder = builder.set_bloom_filter_ndv(*bloom_filter_ndv);
+ builder = builder.set_bloom_filter_max_ndv(*bloom_filter_ndv);
Review Comment:
- due to https://github.com/apache/arrow-rs/pull/9877 which deprecated
set_bloom_filtr_ndv
##########
Cargo.lock:
##########
@@ -3717,12 +3701,6 @@ dependencies = [
"serde_json",
]
-[[package]]
-name = "integer-encoding"
Review Comment:
yay for removing older deps
##########
Cargo.lock:
##########
@@ -6134,17 +6101,6 @@ dependencies = [
"cfg-if",
]
-[[package]]
Review Comment:
no more thrift! We now use the entirely new thrift encoder and not the
thrift generator
##########
datafusion/datasource-parquet/src/row_group_filter.rs:
##########
@@ -955,10 +955,7 @@ mod tests {
let schema =
Arc::new(Schema::new(vec![Field::new("c1", Decimal128(9, 2),
false)]));
let field = PrimitiveTypeField::new("c1", PhysicalType::INT32)
- .with_logical_type(LogicalType::Decimal {
- scale: 2,
- precision: 9,
- })
+ .with_logical_type(LogicalType::decimal(2, 9))
Review Comment:
have to use new helpers added in
- https://github.com/apache/arrow-rs/pull/9996
As the types were changed in
- https://github.com/apache/arrow-rs/pull/9997
##########
datafusion/core/tests/extension_types/pretty_printing.rs:
##########
@@ -40,10 +40,16 @@ async fn create_test_table() -> Result<DataFrame> {
// define data.
let batch = RecordBatch::try_new(
schema,
- vec![Arc::new(FixedSizeBinaryArray::from(vec![
- &[0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0],
- &[0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 0, 1, 2, 3, 5, 6],
- ]))],
+ vec![Arc::new(
Review Comment:
`from` impl was removed because it could panic
- https://github.com/apache/arrow-rs/pull/10019
##########
datafusion/common/src/file_options/parquet_writer.rs:
##########
@@ -812,10 +812,12 @@ mod tests {
);
assert_eq!(
default_writer_props.bloom_filter_properties(&"default".into()),
- Some(&BloomFilterProperties {
- fpp: 0.42,
- ndv: DEFAULT_BLOOM_FILTER_NDV
- }),
+ Some(
+ &BloomFilterProperties::builder()
Review Comment:
Properties are now built with builder:
- https://github.com/apache/arrow-rs/pull/9877
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
