github-actions[bot] commented on PR #22689: URL: https://github.com/apache/datafusion/pull/22689#issuecomment-4591088951
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion-functions-nested v53.1.0 (current) Built [ 34.535s] (current) Parsing datafusion-functions-nested v53.1.0 (current) Parsed [ 0.041s] (current) Building datafusion-functions-nested v53.1.0 (baseline) Built [ 34.589s] (baseline) Parsing datafusion-functions-nested v53.1.0 (baseline) Parsed [ 0.040s] (baseline) Checking datafusion-functions-nested v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.255s] 222 checks: 222 pass, 30 skip Summary no semver update required Finished [ 70.755s] datafusion-functions-nested Building datafusion-physical-expr v53.1.0 (current) Built [ 27.898s] (current) Parsing datafusion-physical-expr v53.1.0 (current) Parsed [ 0.052s] (current) Building datafusion-physical-expr v53.1.0 (baseline) Built [ 27.761s] (baseline) Parsing datafusion-physical-expr v53.1.0 (baseline) Parsed [ 0.057s] (baseline) Checking datafusion-physical-expr v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.417s] 222 checks: 220 pass, 2 fail, 0 warn, 30 skip --- failure function_parameter_count_changed: pub fn parameter count changed --- Description: A publicly-visible function now takes a different number of parameters. ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/function_parameter_count_changed.ron Failed in: datafusion_physical_expr::expressions::lambda now takes 3 parameters instead of 2, in /home/runner/work/datafusion/datafusion/datafusion/physical-expr/src/expressions/lambda.rs:243 --- failure method_parameter_count_changed: pub method parameter count changed --- Description: A publicly-visible method now takes a different number of parameters, not counting the receiver (self) parameter. ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/method_parameter_count_changed.ron Failed in: datafusion_physical_expr::expressions::LambdaExpr::try_new takes 2 parameters in /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/06dd7115d01d285840987edcd0dd32a5798a198a/datafusion/physical-expr/src/expressions/lambda.rs:64, but now takes 3 parameters in /home/runner/work/datafusion/datafusion/datafusion/physical-expr/src/expressions/lambda.rs:76 Summary semver requires new major version: 2 major and 0 minor checks failed Finished [ 57.477s] datafusion-physical-expr Building datafusion-sqllogictest v53.1.0 (current) Built [ 167.777s] (current) Parsing datafusion-sqllogictest v53.1.0 (current) Parsed [ 0.025s] (current) Building datafusion-sqllogictest v53.1.0 (baseline) Built [ 166.163s] (baseline) Parsing datafusion-sqllogictest v53.1.0 (baseline) Parsed [ 0.025s] (baseline) Checking datafusion-sqllogictest v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.114s] 222 checks: 222 pass, 30 skip Summary no semver update required Finished [ 338.517s] datafusion-sqllogictest ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
