andygrove commented on PR #4078: URL: https://github.com/apache/datafusion-comet/pull/4078#issuecomment-4525724272
> > > Thanks @kazuyukitanimura. This looks good overall, but we need to think about configs for this. We have not enabled any JVM UDFs by default yet - they should be opt-in until the UDF functionality is more mature. > > > There is a general discussion on the config approach in #4310 > > > > > > Thanks @andygrove I reverted the changes in native/spark-expr/src/math_funcs/round.rs so that we can choose to use the incompatible native implementations in the future if we need to. We are currently disabling `round` by default, no option to enable. This PR returns JVM compatible results at least. What about merging this PR first for now and that will unblock the TPCDS coverage issue? > > This PR enabled a Comet JVM UDF by default. This would be the first one if we merge it. I don't know if we are ready to enable JVM UDF by default yet. Perhaps if this is re-implemented to use the new UDF codegen approach then it would be gated on `CometConf.COMET_SCALA_UDF_CODEGEN_ENABLED` which is disabled by default. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
