jx2lee commented on code in PR #22309: URL: https://github.com/apache/datafusion/pull/22309#discussion_r3269863355
########## datafusion/sqllogictest/test_files/select.slt: ########## @@ -960,6 +960,12 @@ physical_plan 01)ProjectionExec: expr=[c1@0 >= 2 AND c1@0 <= 3 as select_between_data.c1 BETWEEN Int64(2) AND Int64(3)] 02)--DataSourceExec: partitions=1, partition_sizes=[1] +# regression test: full i64 BETWEEN bounds should not overflow Review Comment: @kumarUjjawal Thanks for the review ! Could i add the test here? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
