asolimando commented on PR #21815:
URL: https://github.com/apache/datafusion/pull/21815#issuecomment-4491220386
@alamb @xudong963, thanks again for your reviews.
I have pushed 3 new commits addressing your latest feedback (force-pushed to
rebase on latest main):
- `bc32cf2`: `StatisticsArgs` struct, `child_stats_for`/`child_stats_of`
helpers, removed `StatisticsContext`
- `53bbf5e`: `child_stats` Vec removed, all lookups go through the cache
- `bf43bc7`: FilterExec chain benchmark
Benchmark numbers unchanged (~26x coalesce chain, ~5x cross-join tree, ~25x
filter chain at depth 50), and the code reads much better with your suggestions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
