zhuqi-lucas commented on code in PR #21956:
URL: https://github.com/apache/datafusion/pull/21956#discussion_r3252432620
##########
datafusion/core/tests/dataframe/mod.rs:
##########
@@ -3268,7 +3268,7 @@ async fn
union_with_mix_of_presorted_and_explicitly_resorted_inputs_with_reparti
UnionExec
DataSourceExec: file_groups={1 group:
[[{testdata}/alltypes_tiny_pages.parquet]]}, projection=[id],
output_ordering=[id@0 ASC NULLS LAST], file_type=parquet
SortExec: expr=[id@0 ASC NULLS LAST], preserve_partitioning=[false]
- DataSourceExec: file_groups={1 group:
[[{testdata}/alltypes_tiny_pages.parquet]]}, projection=[id], file_type=parquet
+ DataSourceExec: file_groups={1 group:
[[{testdata}/alltypes_tiny_pages.parquet]]}, projection=[id],
file_type=parquet, sort_order_for_reorder=[id@0 ASC NULLS LAST]
Review Comment:
Thanks for review! Thought about it — kept `sort_order_for_reorder` rather
than going to `inexact_output_ordering`. The latter parallels the existing
`output_ordering` (which is a contract downstream relies on), but this field is
a runtime *instruction* to the opener — we explicitly drop the source's
`output_ordering` when this fires precisely because the runtime reorder
invalidates the contract. Keeping the "…for_reorder" naming makes the
instruction-vs-claim distinction explicit and pairs cleanly with
`reverse_row_groups` (also an instruction).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
