andygrove commented on code in PR #47: URL: https://github.com/apache/datafusion-java/pull/47#discussion_r3242445705
########## core/src/main/java/org/apache/datafusion/NdJsonReadOptions.java: ########## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.datafusion; + +import org.apache.arrow.vector.types.pojo.Schema; + +/** + * Configuration knobs for newline-delimited JSON sources passed to {@link + * SessionContext#registerJson(String, String, NdJsonReadOptions)} and {@link + * SessionContext#readJson(String, NdJsonReadOptions)}. + * + * <p>Mirrors a subset of DataFusion's {@code NdJsonReadOptions}. All setters return {@code this} + * for fluent chaining. Defaults match the Rust struct: {@code fileExtension = ".json"}, {@code + * fileCompressionType = UNCOMPRESSED}; {@code schemaInferMaxRecords} unset (the DataFusion default + * is used). + * + * <p>{@code FileCompressionType} is reused from {@link CsvReadOptions} since both formats accept + * the same set of compressions. + */ +public final class NdJsonReadOptions { + + private String fileExtension = ".json"; + private CsvReadOptions.FileCompressionType fileCompressionType = Review Comment: If FileCompressType is no longer specific to CSV, we should move it to a shared location -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
