adriangb commented on issue #22065: URL: https://github.com/apache/datafusion/issues/22065#issuecomment-4427473669
@alamb i think this is another reason to do something like https://github.com/apache/datafusion/issues/21835. As it currently stands it’s easy to add a new expression and forget to add it to the proto (it downcast matches), and it’s easy to add a new field to an execution plan or expression and forget to add it (nothing forces you to call a new public function, moving the implements to the struct itself would allow destructuring which forces new fields to be handled). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
