adriangb commented on PR #21739: URL: https://github.com/apache/datafusion/pull/21739#issuecomment-4427242351
> > @kumarUjjawal if you wanted to reduce the diff it might be nice to split [#21739 (comment)](https://github.com/apache/datafusion/pull/21739#issuecomment-4403072067) into a refactor only PR since it's mostly addressing an existing code smell. > > I wanted to complete this work on this PR itself even though the diff is large, hope that's okay 😬 Understand. It’s good by me. @pepijnve please let us know if you’d like to do another round of review or if you’re happy with the way last one was addressed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
