github-actions[bot] commented on PR #22037: URL: https://github.com/apache/datafusion/pull/22037#issuecomment-4417029939
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion v53.1.0 (current) Built [ 83.753s] (current) Parsing datafusion v53.1.0 (current) Parsed [ 0.035s] (current) Building datafusion v53.1.0 (baseline) Built [ 81.922s] (baseline) Parsing datafusion v53.1.0 (baseline) Parsed [ 0.034s] (baseline) Checking datafusion v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.634s] 222 checks: 222 pass, 30 skip Summary no semver update required Finished [ 168.285s] datafusion Building datafusion-expr v53.1.0 (current) Built [ 26.552s] (current) Parsing datafusion-expr v53.1.0 (current) Parsed [ 0.072s] (current) Building datafusion-expr v53.1.0 (baseline) Built [ 26.472s] (baseline) Parsing datafusion-expr v53.1.0 (baseline) Parsed [ 0.071s] (baseline) Checking datafusion-expr v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 1.087s] 222 checks: 221 pass, 1 fail, 0 warn, 30 skip --- failure constructible_struct_adds_field: externally-constructible struct adds field --- Description: A pub struct constructible with a struct literal has a new pub field. Existing struct literals must be updated to include the new field. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/constructible_struct_adds_field.ron Failed in: field RecursiveQuery.schema in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:2257 field RecursiveQuery.schema in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:2257 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 55.310s] datafusion-expr Building datafusion-physical-plan v53.1.0 (current) Built [ 33.798s] (current) Parsing datafusion-physical-plan v53.1.0 (current) Parsed [ 0.123s] (current) Building datafusion-physical-plan v53.1.0 (baseline) Built [ 33.175s] (baseline) Parsing datafusion-physical-plan v53.1.0 (baseline) Parsed [ 0.132s] (baseline) Checking datafusion-physical-plan v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.606s] 222 checks: 221 pass, 1 fail, 0 warn, 30 skip --- failure method_parameter_count_changed: pub method parameter count changed --- Description: A publicly-visible method now takes a different number of parameters, not counting the receiver (self) parameter. ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/method_parameter_count_changed.ron Failed in: datafusion_physical_plan::recursive_query::RecursiveQueryExec::try_new takes 4 parameters in /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/a365a0bdcd6b40d46b64850084613a7c5029cb42/datafusion/physical-plan/src/recursive_query.rs:85, but now takes 5 parameters in /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/recursive_query.rs:86 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 69.117s] datafusion-physical-plan Building datafusion-proto v53.1.0 (current) Built [ 55.211s] (current) Parsing datafusion-proto v53.1.0 (current) Parsed [ 0.134s] (current) Building datafusion-proto v53.1.0 (baseline) Built [ 55.328s] (baseline) Parsing datafusion-proto v53.1.0 (baseline) Parsed [ 0.137s] (baseline) Checking datafusion-proto v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 1.678s] 222 checks: 222 pass, 30 skip Summary no semver update required Finished [ 114.669s] datafusion-proto Building datafusion-sql v53.1.0 (current) Built [ 40.793s] (current) Parsing datafusion-sql v53.1.0 (current) Parsed [ 0.030s] (current) Building datafusion-sql v53.1.0 (baseline) Built [ 40.409s] (baseline) Parsing datafusion-sql v53.1.0 (baseline) Parsed [ 0.031s] (baseline) Checking datafusion-sql v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.260s] 222 checks: 222 pass, 30 skip Summary no semver update required Finished [ 82.733s] datafusion-sql Building datafusion-sqllogictest v53.1.0 (current) Built [ 135.082s] (current) Parsing datafusion-sqllogictest v53.1.0 (current) Parsed [ 0.021s] (current) Building datafusion-sqllogictest v53.1.0 (baseline) Built [ 135.509s] (baseline) Parsing datafusion-sqllogictest v53.1.0 (baseline) Parsed [ 0.022s] (baseline) Checking datafusion-sqllogictest v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.084s] 222 checks: 222 pass, 30 skip Summary no semver update required Finished [ 275.097s] datafusion-sqllogictest ``` </details> <!-- semver-check-comment --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
