pepijnve commented on PR #22027: URL: https://github.com/apache/datafusion/pull/22027#issuecomment-4395936483
> the documented preconditions are relaxed I think the change itself makes sense. There is also a change in postconditions of the functions though. Before the output type of the interval was guaranteed to match the input type. After that change that postcondition is less strict. I'm wondering if that could cause problems for existing code. Relaxing the preconditions will cause existing code to follow its success code path instead of its error code path. The change in postconditions may result in an assumption violation for those success code paths. I don't know if this is mostly a theoretical issue, or something that requires actual consideration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
