petern48 commented on PR #20610: URL: https://github.com/apache/datafusion/pull/20610#issuecomment-4380469835
Been busy. I'm just going to close this. Back when I investigated implementing this in `simplify()`, I found that `contains` was gated behind a different feature flag [string_expressions](https://github.com/apache/datafusion/blob/32f51ec655906f442c18ecfec041214845af2cd3/datafusion/functions/src/lib.rs#L101) than `regexp_match` [regex_expressions](https://github.com/apache/datafusion/blob/32f51ec655906f442c18ecfec041214845af2cd3/datafusion/functions/src/lib.rs#L129), so we would need to implement the logic conditioned on the string feature also being on. Felt kinda overkill for this very specific optimization, given there's no logic like that anywhere else in the codebase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
