adriangb commented on PR #21975: URL: https://github.com/apache/datafusion/pull/21975#issuecomment-4373097924
Thanks @jayshrivastava ! My main concern with merging this right now is that it doesn't seem like a big pain point / blocker anymore to have this API. And removing it is code churn. Especially if we find a user for it later. I'm thinking in particular about other "thin, runtime only" expression wrappers, e.g. `AdaptiveSelectivityFilterExpr` in https://github.com/apache/datafusion/pull/20160/changes#diff-6bf8881dc0e8a0da8ea68022633bbdc4a42e91287c059f6bc55050586d184bd7. I feel there may even be others that already exist in DataFusion that we just haven't wired up 🤔 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
