github-actions[bot] commented on PR #21975: URL: https://github.com/apache/datafusion/pull/21975#issuecomment-4359887529
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning origin/main Building datafusion-ffi v53.1.0 (current) Built [ 61.374s] (current) Parsing datafusion-ffi v53.1.0 (current) Parsed [ 0.055s] (current) Building datafusion-ffi v53.1.0 (baseline) Built [ 60.835s] (baseline) Parsing datafusion-ffi v53.1.0 (baseline) Parsed [ 0.055s] (baseline) Checking datafusion-ffi v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.267s] 222 checks: 220 pass, 1 fail, 1 warn, 30 skip --- failure struct_pub_field_missing: pub struct's pub field removed or renamed --- Description: A publicly-visible struct has at least one public field that is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/struct_pub_field_missing.ron Failed in: field snapshot of struct FFI_PhysicalExpr, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-origin_main/9807f5f9f6c047ef5ab58029fda0cd09dbaa57c2/datafusion/ffi/src/physical_expr/mod.rs:115 --- warning repr_c_plain_struct_fields_reordered: struct fields reordered in repr(C) struct --- Description: A public repr(C) struct had its fields reordered. This can change the struct's memory layout, possibly breaking FFI use cases that depend on field position and order. ref: https://doc.rust-lang.org/reference/type-layout.html#reprc-structs impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/repr_c_plain_struct_fields_reordered.ron Failed in: FFI_PhysicalExpr.snapshot_generation moved from position 15 to 14, in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/physical_expr/mod.rs:115 FFI_PhysicalExpr.is_volatile_node moved from position 16 to 15, in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/physical_expr/mod.rs:117 FFI_PhysicalExpr.display moved from position 17 to 16, in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/physical_expr/mod.rs:120 FFI_PhysicalExpr.hash moved from position 18 to 17, in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/physical_expr/mod.rs:123 FFI_PhysicalExpr.clone moved from position 19 to 18, in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/physical_expr/mod.rs:127 FFI_PhysicalExpr.release moved from position 20 to 19, in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/physical_expr/mod.rs:130 FFI_PhysicalExpr.version moved from position 21 to 20, in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/physical_expr/mod.rs:133 FFI_PhysicalExpr.private_data moved from position 22 to 21, in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/physical_expr/mod.rs:137 FFI_PhysicalExpr.library_marker_id moved from position 23 to 22, in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/physical_expr/mod.rs:141 Summary semver requires new major version: 1 major and 0 minor checks failed Warning produced 1 major and 0 minor level warnings Finished [ 124.087s] datafusion-ffi Building datafusion-physical-expr v53.1.0 (current) Built [ 26.492s] (current) Parsing datafusion-physical-expr v53.1.0 (current) Parsed [ 0.044s] (current) Building datafusion-physical-expr v53.1.0 (baseline) Built [ 26.988s] (baseline) Parsing datafusion-physical-expr v53.1.0 (baseline) Parsed [ 0.044s] (baseline) Checking datafusion-physical-expr v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.298s] 222 checks: 222 pass, 30 skip Summary no semver update required Finished [ 54.882s] datafusion-physical-expr Building datafusion-physical-expr-common v53.1.0 (current) Built [ 21.061s] (current) Parsing datafusion-physical-expr-common v53.1.0 (current) Parsed [ 0.020s] (current) Building datafusion-physical-expr-common v53.1.0 (baseline) Built [ 21.050s] (baseline) Parsing datafusion-physical-expr-common v53.1.0 (baseline) Parsed [ 0.020s] (baseline) Checking datafusion-physical-expr-common v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.205s] 222 checks: 220 pass, 2 fail, 0 warn, 30 skip --- failure function_missing: pub fn removed or renamed --- Description: A publicly-visible function cannot be imported by its prior path. A `pub use` may have been removed, or the function itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/function_missing.ron Failed in: function datafusion_physical_expr_common::physical_expr::snapshot_physical_expr_opt, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-origin_main/9807f5f9f6c047ef5ab58029fda0cd09dbaa57c2/datafusion/physical-expr-common/src/physical_expr.rs:631 function datafusion_physical_expr_common::physical_expr::snapshot_physical_expr, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-origin_main/9807f5f9f6c047ef5ab58029fda0cd09dbaa57c2/datafusion/physical-expr-common/src/physical_expr.rs:612 --- failure trait_method_missing: pub trait method removed or renamed --- Description: A trait method is no longer callable, and may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#trait-item-signature impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/trait_method_missing.ron Failed in: method snapshot of trait PhysicalExpr, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-origin_main/9807f5f9f6c047ef5ab58029fda0cd09dbaa57c2/datafusion/physical-expr-common/src/physical_expr.rs:397 Summary semver requires new major version: 2 major and 0 minor checks failed Finished [ 43.237s] datafusion-physical-expr-common Building datafusion-proto v53.1.0 (current) Built [ 57.230s] (current) Parsing datafusion-proto v53.1.0 (current) Parsed [ 0.138s] (current) Building datafusion-proto v53.1.0 (baseline) Built [ 56.490s] (baseline) Parsing datafusion-proto v53.1.0 (baseline) Parsed [ 0.136s] (baseline) Checking datafusion-proto v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 1.631s] 222 checks: 221 pass, 1 fail, 0 warn, 30 skip --- failure enum_variant_added: enum variant added on exhaustive enum --- Description: A publicly-visible enum without #[non_exhaustive] has a new variant. ref: https://doc.rust-lang.org/cargo/reference/semver.html#enum-variant-new impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/enum_variant_added.ron Failed in: variant ExprType:DynamicFilter in /home/runner/work/datafusion/datafusion/datafusion/proto/src/generated/prost.rs:1393 variant ExprType:DynamicFilter in /home/runner/work/datafusion/datafusion/datafusion/proto/src/generated/prost.rs:1393 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 117.603s] datafusion-proto Building datafusion-pruning v53.1.0 (current) Built [ 38.618s] (current) Parsing datafusion-pruning v53.1.0 (current) Parsed [ 0.011s] (current) Building datafusion-pruning v53.1.0 (baseline) Built [ 38.546s] (baseline) Parsing datafusion-pruning v53.1.0 (baseline) Parsed [ 0.013s] (baseline) Checking datafusion-pruning v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.079s] 222 checks: 222 pass, 30 skip Summary no semver update required Finished [ 78.441s] datafusion-pruning ``` </details> <!-- semver-check-comment --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
