kosiew commented on code in PR #21912:
URL: https://github.com/apache/datafusion/pull/21912#discussion_r3180853057
##########
datafusion/core/tests/memory_limit/mod.rs:
##########
@@ -343,7 +343,7 @@ async fn oom_recursive_cte() {
TestCase::new()
.with_query(
"WITH RECURSIVE nodes AS (
- SELECT 1 as id
+ SELECT id FROM (VALUES (1), (NULL)) AS t(id) WHERE id IS NOT NULL
Review Comment:
`SELECT 1 as id`
would fail with
```
Error during planning: Cannot project plan column 0 ('id') to expected
output field 'id': field nullability differs (input field: Field { name: "id",
data_type: Int64, nullable: true }, expected field: Field { name: "id",
data_type: Int64 })
```
under the stricter nullability check.
Should I amend the check to allow safe nullability widening (non-null ->
nullable)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
