tschwarzinger commented on code in PR #21714:
URL: https://github.com/apache/datafusion/pull/21714#discussion_r3179989899
##########
datafusion/sql/src/planner.rs:
##########
@@ -658,6 +661,21 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
// If no type_planner can handle this type, use the default conversion
match sql_type {
+ // Canonical Arrow extension types
+ SQLDataType::Uuid => Ok(Arc::new(
Review Comment:
Maybe instead of writing the metadata ourselves, we could use the arrow-rs
extension type. You should be able to do something (IIRC) like
`.with_extension_type(arrow_schema::<..>::Json)`.
Then we don't have to mess around with the constants and will get a valid
name/metadata pair.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
