cyberbeam524 commented on code in PR #21714:
URL: https://github.com/apache/datafusion/pull/21714#discussion_r3172611607
##########
datafusion/sql/src/planner.rs:
##########
@@ -641,6 +641,21 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
// If no type_planner can handle this type, use the default conversion
match sql_type {
+ // Canonical Arrow extension types
+ SQLDataType::Uuid => Ok(Arc::new(
+ Field::new("", DataType::FixedSizeBinary(16),
true).with_metadata(
+ HashMap::from([(
+ "ARROW:extension:name".to_string(),
Review Comment:
Done! I've updated the implementation to use EXTENSION_TYPE_NAME_KEY and
EXTENSION_TYPE_METADATA_KEY from arrow_schema. This is much cleaner and keeps
us aligned with the Arrow specification. Thanks for the suggestion!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
