huymq1710 commented on code in PR #21948:
URL: https://github.com/apache/datafusion/pull/21948#discussion_r3178184380
##########
datafusion/functions/benches/to_char.rs:
##########
@@ -278,6 +278,66 @@ fn criterion_benchmark(c: &mut Criterion) {
)
})
});
+
+ // These bellow 02 benchmarks use Date32 data with format strings that
contain
+ // time specifiers (%H, %M, %S, ...). Arrow's Date32 formatter cannot
+ // handle time specifiers and falls back to a Date64 cast.
+
+ // Covers full fallback (every row triggers the cast)
+ c.bench_function("to_char_array_date32_datetime_patterns_1000", |b| {
Review Comment:
Got it, I temporary removed benchmark changes, I will create other PR to add
back after this PR is merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
