SubhamSinghal commented on PR #21775: URL: https://github.com/apache/datafusion/pull/21775#issuecomment-4363477283
@2010YOUY01 Thanks for reviewing this PR. I have add micro-benchmark query and fixed metrics issue. > Additionally, to further optimize this in the future, probably we can create a new hash map implementation that avoids inserting duplicates at the building phase, this way both build time and probe time can be optimized Thanks for highlighting this. This looks a like good learning opportunity to me, will take it up as followup task. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
