github-actions[bot] commented on PR #21775: URL: https://github.com/apache/datafusion/pull/21775#issuecomment-4359306983
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning origin/main Building datafusion-physical-plan v53.1.0 (current) Built [ 26.669s] (current) Parsing datafusion-physical-plan v53.1.0 (current) Parsed [ 0.103s] (current) Building datafusion-physical-plan v53.1.0 (baseline) Built [ 27.285s] (baseline) Parsing datafusion-physical-plan v53.1.0 (baseline) Parsed [ 0.102s] (baseline) Checking datafusion-physical-plan v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.618s] 222 checks: 221 pass, 1 fail, 0 warn, 30 skip --- failure trait_method_added: pub trait method added --- Description: A non-sealed public trait added a new method without a default implementation, which breaks downstream implementations of the trait ref: https://doc.rust-lang.org/cargo/reference/semver.html#trait-new-item-no-default impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/trait_method_added.ron Failed in: trait method datafusion_physical_plan::joins::utils::JoinHashMapType::get_first_match in file /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/joins/join_hash_map.rs:157 trait method datafusion_physical_plan::joins::join_hash_map::JoinHashMapType::get_first_match in file /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/joins/join_hash_map.rs:157 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 56.985s] datafusion-physical-plan ``` </details> <!-- semver-check-comment --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
