adriangb commented on issue #21835: URL: https://github.com/apache/datafusion/issues/21835#issuecomment-4363079342
@alamb having experimented in https://github.com/apache/datafusion/pull/21966 the now somewhat obvious issue with a generic Serde trait approach is that it is incompatible with fixed schema serialization formats like Protobuf. E.g. consider one branch in the trait implementation ads a field and another doesn't. Since there is no static schema it is not possible to form a single valid protobuf model even dynamically. So if we want this for protobuf (the only current offender as far as I'm concerned) I think we need to go with something like https://github.com/apache/datafusion/pull/21949 and leave a generic Serde approach for later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
