jayshrivastava commented on issue #21835: URL: https://github.com/apache/datafusion/issues/21835#issuecomment-4356562997
Overall, I support having `from_proto` and `to_proto` to avoid leaking internals. Merging `datafusion-proto-common` into `datafusion-proto`/`datafusion-proto-models` makes sense too. I doubt there's many use cases for importing `datafusion-proto-common` to serialize primitives without importing `datafusion-proto` for plan nodes / expressions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
