pepijnve commented on code in PR #21739:
URL: https://github.com/apache/datafusion/pull/21739#discussion_r3167973215
##########
datafusion/physical-expr/src/aggregate.rs:
##########
@@ -347,8 +375,13 @@ impl AggregateFunctionExpr {
}
/// Simplified name for `tree` explain.
- pub fn human_display(&self) -> &str {
- &self.human_display
+ pub fn human_display(&self) -> Option<&str> {
+ self.human_display.as_deref()
+ }
+
+ #[doc(hidden)]
+ pub fn has_aliased_human_display(&self) -> bool {
+ self.human_display_is_aliased
Review Comment:
The downside is that I can now create a conflicting situation where the
display string _is_ aliased but the boolean indicates it isn't and vice versa.
`strip_alias_suffix` is already kind of parsing the display string as well, so
maybe the fact that we need to inspect the string value isn't that big of a
problem?
The main reason I asked is because the addition of this field triggers a
protobuf change as well and I was wondering if that was desirable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
