github-actions[bot] commented on PR #21739: URL: https://github.com/apache/datafusion/pull/21739#issuecomment-4351567677
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning origin/main Building datafusion v53.1.0 (current) Built [ 94.456s] (current) Parsing datafusion v53.1.0 (current) Parsed [ 0.038s] (current) Building datafusion v53.1.0 (baseline) Built [ 93.985s] (baseline) Parsing datafusion v53.1.0 (baseline) Parsed [ 0.039s] (baseline) Checking datafusion v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.923s] 222 checks: 221 pass, 1 fail, 0 warn, 30 skip --- failure function_parameter_count_changed: pub fn parameter count changed --- Description: A publicly-visible function now takes a different number of parameters. ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/function_parameter_count_changed.ron Failed in: datafusion::physical_planner::create_aggregate_expr_with_name_and_maybe_filter now takes 7 parameters instead of 6, in /home/runner/work/datafusion/datafusion/datafusion/core/src/physical_planner.rs:2490 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 191.867s] datafusion Building datafusion-expr v53.1.0 (current) Built [ 29.013s] (current) Parsing datafusion-expr v53.1.0 (current) Parsed [ 0.078s] (current) Building datafusion-expr v53.1.0 (baseline) Built [ 26.498s] (baseline) Parsing datafusion-expr v53.1.0 (baseline) Parsed [ 0.079s] (baseline) Checking datafusion-expr v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 1.823s] 222 checks: 220 pass, 2 fail, 0 warn, 30 skip --- failure constructible_struct_adds_field: externally-constructible struct adds field --- Description: A pub struct constructible with a struct literal has a new pub field. Existing struct literals must be updated to include the new field. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/constructible_struct_adds_field.ron Failed in: field Alias.is_internal in /home/runner/work/datafusion/datafusion/datafusion/expr/src/expr.rs:673 --- failure enum_struct_variant_field_added: pub enum struct variant field added --- Description: An enum's exhaustive struct variant has a new field, which has to be included when constructing or matching on this variant. ref: https://doc.rust-lang.org/reference/attributes/type_system.html#the-non_exhaustive-attribute impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/enum_struct_variant_field_added.ron Failed in: field is_internal_generated of variant SavedName::Saved in /home/runner/work/datafusion/datafusion/datafusion/expr/src/expr_rewriter/mod.rs:312 Summary semver requires new major version: 2 major and 0 minor checks failed Finished [ 59.106s] datafusion-expr Building datafusion-functions-aggregate v53.1.0 (current) Built [ 29.623s] (current) Parsing datafusion-functions-aggregate v53.1.0 (current) Parsed [ 0.046s] (current) Building datafusion-functions-aggregate v53.1.0 (baseline) Built [ 29.740s] (baseline) Parsing datafusion-functions-aggregate v53.1.0 (baseline) Parsed [ 0.049s] (baseline) Checking datafusion-functions-aggregate v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.268s] 222 checks: 222 pass, 30 skip Summary no semver update required Finished [ 61.665s] datafusion-functions-aggregate Building datafusion-optimizer v53.1.0 (current) Built [ 25.958s] (current) Parsing datafusion-optimizer v53.1.0 (current) Parsed [ 0.028s] (current) Building datafusion-optimizer v53.1.0 (baseline) Built [ 26.385s] (baseline) Parsing datafusion-optimizer v53.1.0 (baseline) Parsed [ 0.031s] (baseline) Checking datafusion-optimizer v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.231s] 222 checks: 222 pass, 30 skip Summary no semver update required Finished [ 54.163s] datafusion-optimizer Building datafusion-physical-expr v53.1.0 (current) Built [ 24.494s] (current) Parsing datafusion-physical-expr v53.1.0 (current) Parsed [ 0.046s] (current) Building datafusion-physical-expr v53.1.0 (baseline) Built [ 24.783s] (baseline) Parsing datafusion-physical-expr v53.1.0 (baseline) Parsed [ 0.047s] (baseline) Checking datafusion-physical-expr v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.422s] 222 checks: 222 pass, 30 skip Summary no semver update required Finished [ 51.329s] datafusion-physical-expr Building datafusion-physical-plan v53.1.0 (current) Built [ 31.936s] (current) Parsing datafusion-physical-plan v53.1.0 (current) Parsed [ 0.134s] (current) Building datafusion-physical-plan v53.1.0 (baseline) Built [ 32.150s] (baseline) Parsing datafusion-physical-plan v53.1.0 (baseline) Parsed [ 0.135s] (baseline) Checking datafusion-physical-plan v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.807s] 222 checks: 222 pass, 30 skip Summary no semver update required Finished [ 67.278s] datafusion-physical-plan Building datafusion-proto v53.1.0 (current) Built [ 54.741s] (current) Parsing datafusion-proto v53.1.0 (current) Parsed [ 0.146s] (current) Building datafusion-proto v53.1.0 (baseline) Built [ 55.649s] (baseline) Parsing datafusion-proto v53.1.0 (baseline) Parsed [ 0.146s] (baseline) Checking datafusion-proto v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 2.345s] 222 checks: 221 pass, 1 fail, 0 warn, 30 skip --- failure constructible_struct_adds_field: externally-constructible struct adds field --- Description: A pub struct constructible with a struct literal has a new pub field. Existing struct literals must be updated to include the new field. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/constructible_struct_adds_field.ron Failed in: field PhysicalAggregateExprNode.human_display_is_aliased in /home/runner/work/datafusion/datafusion/datafusion/proto/src/generated/prost.rs:1428 field PhysicalAggregateExprNode.human_display_is_aliased in /home/runner/work/datafusion/datafusion/datafusion/proto/src/generated/prost.rs:1428 field AliasNode.is_internal in /home/runner/work/datafusion/datafusion/datafusion/proto/src/generated/prost.rs:797 field AliasNode.is_internal in /home/runner/work/datafusion/datafusion/datafusion/proto/src/generated/prost.rs:797 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 115.868s] datafusion-proto Building datafusion-sql v53.1.0 (current) Built [ 40.021s] (current) Parsing datafusion-sql v53.1.0 (current) Parsed [ 0.032s] (current) Building datafusion-sql v53.1.0 (baseline) Built [ 39.705s] (baseline) Parsing datafusion-sql v53.1.0 (baseline) Parsed [ 0.032s] (baseline) Checking datafusion-sql v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.312s] 222 checks: 222 pass, 30 skip Summary no semver update required Finished [ 81.841s] datafusion-sql Building datafusion-sqllogictest v53.1.0 (current) Built [ 139.126s] (current) Parsing datafusion-sqllogictest v53.1.0 (current) Parsed [ 0.025s] (current) Building datafusion-sqllogictest v53.1.0 (baseline) Built [ 139.936s] (baseline) Parsing datafusion-sqllogictest v53.1.0 (baseline) Parsed [ 0.023s] (baseline) Checking datafusion-sqllogictest v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.116s] 222 checks: 222 pass, 30 skip Summary no semver update required Finished [ 283.250s] datafusion-sqllogictest ``` </details> <!-- semver-check-comment --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
