coderfender commented on code in PR #4126:
URL: https://github.com/apache/datafusion-comet/pull/4126#discussion_r3165912198
##########
spark/src/test/scala/org/apache/spark/sql/comet/CometPlanStabilitySuite.scala:
##########
@@ -286,7 +288,9 @@ class CometTPCDSV1_4_PlanStabilitySuite extends
CometPlanStabilitySuite {
}
class CometTPCDSV2_7_PlanStabilitySuite extends CometPlanStabilitySuite {
- private val planName = if (isSpark41Plus) {
+ private val planName = if (isSpark42Plus) {
+ "approved-plans-v2_7-spark4_2"
+ } else if (isSpark41Plus) {
"approved-plans-v2_7-spark4_1"
} else if (isSpark40Plus) {
"approved-plans-v2_7-spark4_0"
Review Comment:
nit : could probably make a method to return the right plan based on spark
version to keep it module and easy to fix / build in future ?
##########
spark/src/test/scala/org/apache/comet/exec/CometExec3_4PlusSuite.scala:
##########
@@ -157,6 +163,7 @@ class CometExec3_4PlusSuite extends CometTestBase {
}
test("test BloomFilterMightContain from random input") {
+ assume(!isSpark42Plus,
"https://github.com/apache/datafusion-comet/issues/4142";)
Review Comment:
Interesting why this test would fail when we already ignore it
with`isSpark41Plus` tag ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
