andygrove commented on code in PR #4126:
URL: https://github.com/apache/datafusion-comet/pull/4126#discussion_r3163865018
##########
spark/src/test/scala/org/apache/comet/exec/CometExec3_4PlusSuite.scala:
##########
@@ -45,15 +45,19 @@ class CometExec3_4PlusSuite extends CometTestBase {
override def beforeAll(): Unit = {
super.beforeAll()
- // Register 'might_contain' to builtin.
- spark.sessionState.functionRegistry.registerFunction(
- func_might_contain,
- new ExpressionInfo(classOf[BloomFilterMightContain].getName,
"might_contain"),
- (children: Seq[Expression]) => BloomFilterMightContain(children.head,
children(1)))
+ if (!isSpark42Plus) {
Review Comment:
this whole suite failed with Spark 4.2 - the individual tests have the links
to the issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
