blaginin commented on PR #21941: URL: https://github.com/apache/datafusion/pull/21941#issuecomment-4348024928
Now it will take 2x16 minutes to perform a merge (16 mins to put the PR in the queue + 16 mins to merge in the queue). I think that's OK since it's all automated. But we can actually make it MUCH faster - 2x6 mins instead. <img width="564" height="658" alt="image" src="https://github.com/user-attachments/assets/5059c18d-cbd5-44c2-8b8f-eacc650f22fd"; /> You can see that the actual bottleneck is the Mac OS tests - that's because runs-on doesn't support them. My ideas: - kill the Mac OS tests. Although every three months or so there's 1-2 PRs that fail JUST on them, so probably not a good idea. - introduce an "Optional Mac OS Check": this won't run on push to a PR, but will run when the PR is in the merge queue. So instead of 2x16 mins it'll be just 1x16 mins (only in the merge queue). We can do the same with extended tests, which currently aren't required and only run on develop in full. - work with the infra team to get access to more performant github runners. Can take a while but i'm happy to do that! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
