blaginin opened a new pull request, #21941: URL: https://github.com/apache/datafusion/pull/21941
Closes https://github.com/apache/datafusion/issues/6880 Follow up on https://github.com/apache/datafusion/pull/17538 and https://github.com/apache/datafusion/pull/21239 https://github.com/apache/datafusion/pull/21239 seems to be working fine - time to make all the rust changes required to merge it. This brings two cool things: 1. The most important one - the "merge when ready" button now works 🚀 <img width="923" height="285" alt="image" src="https://github.com/user-attachments/assets/4f11ecb6-e1d9-473f-815f-b57488042dd3"; /> You can click this button any time, even right after opening a PR. It will be automatically merged when: - all required CI checks (which now include rust) are passing - you get an approval I think this should help quite a bit. A lot of people get an approval, push a nit, and then sit waiting for CI to finish. No more waiting!! 2. We protect ourselves from logical conflicts: cases where develop was passing before, but someone merged something in the meantime and now your change is broken on develop - and you don't find out until after you merge. We hit this almost every month. One downside: before, clicking merge would happen instantly. Now you'll have to wait 20 minutes. But you don't actually have to wait - github will do the work itself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
