andygrove commented on code in PR #1624:
URL:
https://github.com/apache/datafusion-ballista/pull/1624#discussion_r3163517206
##########
ballista/executor/src/executor_process.rs:
##########
@@ -261,6 +296,21 @@ pub async fn start_executor_process(
})
});
+ let runtime_producer = if let Some(total) = opt.memory_pool_size {
+ let producer = wrap_runtime_producer_with_memory_pool(
+ runtime_producer,
+ total,
+ concurrent_tasks,
+ )?;
+ let per_task = total / concurrent_tasks as u64;
Review Comment:
This is the approach that we use in Comet - each task gets its own fair pool
and within a task, the operators share that pool. This keeps things predictable
and stable.
We can certainly explore adding other config options in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
