goingforstudying-ctrl commented on PR #1593:
URL:
https://github.com/apache/datafusion-ballista/pull/1593#issuecomment-4346285156
Hi @martin-g,
Thank you for the detailed review! I've corrected the TUI navigation
documentation based on your feedback:
**Changes made:**
1. **Tab switching**: Replaced `Tab` with specific keybindings:
- `j` → Jobs tab
- `e` → Executors tab
- `m` → Metrics tab
2. **Column sorting**: Replaced `←/→` with `1/2/3` keys, with clarification
that pressing the same key again reverses the sort order.
3. **Not-yet-implemented features**: I see that some features mentioned
(like Scheduler Info tab) depend on #1574. Should I mark those as "coming soon"
or remove them until #1574 merges?
Here's the diff for the fix:
```diff
diff --git a/docs/source/user-guide/cli.md b/docs/source/user-guide/cli.md
index fa3dccf5..b2e28888 100644
--- a/docs/source/user-guide/cli.md
+++ b/docs/source/user-guide/cli.md
@@ -162,9 +162,11 @@ The TUI provides the following views:
| Key | Action |
| --------- | ------------------------------------------------ |
-| `Tab` | Switch between Executors, Jobs, and Metrics tabs |
+| `j` | Switch to Jobs tab |
+| `e` | Switch to Executors tab |
+| `m` | Switch to Metrics tab |
| `↑` / `↓` | Navigate rows in the current table |
-| `←` / `→` | Change sort column |
+| `1` / `2` / `3` | Toggle sort by column (press again to reverse) |
| `Enter` | Open details popup for the selected job |
| `Esc` | Close popup or quit details view |
| `q` | Quit the TUI |
```
Please let me know if any further adjustments are needed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
