comphead commented on code in PR #4139:
URL: https://github.com/apache/datafusion-comet/pull/4139#discussion_r3162143744
##########
spark/src/main/spark-3.4/org/apache/comet/shims/CometExprShim.scala:
##########
@@ -33,20 +33,21 @@ trait CometExprShim extends CommonStringExprs {
protected def evalMode(c: Cast): CometEvalMode.Value =
CometEvalModeUtil.fromSparkEvalMode(c.evalMode)
- protected def binaryOutputStyle: BinaryOutputStyle =
BinaryOutputStyle.HEX_DISCRETE
+ def binaryOutputStyle: BinaryOutputStyle = BinaryOutputStyle.HEX_DISCRETE
+
+ def versionSpecificStringExpressions: Map[Class[_ <: Expression],
CometExpressionSerde[_]] =
Review Comment:
```suggestion
def sparkVersionSpecificStringExpressions: Map[Class[_ <: Expression],
CometExpressionSerde[_]] =
```
?
Otherwise it is not clear what version referring to, if its spark, comet,
etc?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
