tschwarzinger commented on code in PR #21714: URL: https://github.com/apache/datafusion/pull/21714#discussion_r3160465335
########## datafusion/sqllogictest/test_files/sql_extension_types.slt: ########## @@ -0,0 +1,137 @@ +# Licensed to the Apache Software Foundation (ASF) under one Review Comment: I think it would be great if we register the extension types for these tests. I've prepared a follow-up PR for that: https://github.com/apache/datafusion/compare/main...tschwarzinger:datafusion:extension-types-in-slt-tests-2?expand=1 The difference would be that i) we would test the extension type system and ii) get prettier formatting for values: ```text # CAST to UUID preserves extension metadata query ?T SELECT CAST(arrow_cast(X'00010203040506070809000102030506', 'FixedSizeBinary(16)') AS UUID), arrow_metadata(CAST(arrow_cast(X'00010203040506070809000102030506', 'FixedSizeBinary(16)') AS UUID), 'ARROW:extension:name'); ---- 00010203-0405-0607-0809-000102030506 arrow.uuid ``` But I think we can do that in a follow-up (we need you fix for casting for this to work) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
