andygrove commented on code in PR #4076:
URL: https://github.com/apache/datafusion-comet/pull/4076#discussion_r3157409829
##########
spark/src/main/spark-4.0/org/apache/comet/shims/CometExprShim.scala:
##########
@@ -144,6 +145,29 @@ trait CometExprShim extends CommonStringExprs {
case _ => None
}
+ case ms: MapSort =>
Review Comment:
yeah the PR was started before 4.1 was added, and unmerging broke the tests.
added shims for 4.1 and 4.2 now
##########
spark/src/main/spark-4.0/org/apache/comet/shims/CometExprShim.scala:
##########
@@ -144,6 +145,29 @@ trait CometExprShim extends CommonStringExprs {
case _ => None
}
+ case ms: MapSort =>
Review Comment:
yeah the PR was started before 4.1 was added, and upmerging broke the tests.
added shims for 4.1 and 4.2 now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
