andygrove commented on PR #4076: URL: https://github.com/apache/datafusion-comet/pull/4076#issuecomment-4338866403
Microbenchmark numbers from `native/spark-expr/benches/map_sort.rs` ([6e832541d](https://github.com/apache/datafusion-comet/pull/4076/commits/6e832541d)). Each case is a batch of 8192 maps; "old" is the per-map `take` + `concat` impl, "new" is the global-permutation + single `take` impl. Release build, M-series Mac. | Case | Entries/map | Old | New | Speedup | | ------------------ | ----------- | ---------- | ---------- | ------- | | `int_keys/4` | 4 | 3.99 ms | 0.77 ms | 5.2x | | `int_keys/16` | 16 | 4.44 ms | 1.25 ms | 3.6x | | `int_keys/64` | 64 | 5.02 ms | 1.62 ms | 3.1x | | `string_keys/4` | 4 | 4.52 ms | 0.97 ms | 4.7x | | `string_keys/16` | 16 | 7.16 ms | 3.87 ms | 1.85x | | `string_keys/64` | 64 | 8.95 ms | 4.24 ms | 2.1x | The biggest wins are the small-map cases where the per-map struct copies and trailing `concat` dominated. To run locally: ``` cd native && cargo bench --bench map_sort ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
