milenkovicm commented on code in PR #1614:
URL:
https://github.com/apache/datafusion-ballista/pull/1614#discussion_r3156807694
##########
python/python/ballista/extension.py:
##########
@@ -163,7 +163,9 @@ def _to_internal_df(self):
def write_csv(self, path, with_header=False):
df = self._to_internal_df()
- df.write_csv(path, with_header)
+ # The PyO3-bound DataFrame.write_csv requires write_options to be
+ # passed even though its Python signature shows a None default.
+ df.write_csv(path, with_header, None)
Review Comment:
as with #1590 we're missing `write_options: DataFrameWriteOptions`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
