shivbhatia10 commented on code in PR #21892:
URL: https://github.com/apache/datafusion/pull/21892#discussion_r3155906772


##########
datafusion/physical-plan/src/execution_plan.rs:
##########
@@ -1576,6 +1602,10 @@ pub enum CardinalityEffect {
     LowerEqual,
     /// The operator may produce more output rows than it receives input rows
     GreaterEqual,
+    /// The operator concatenates rows from multiple inputs and produces
+    /// exactly the sum of its inputs' output rows (e.g. `UnionExec`,
+    /// `InterleaveExec`).
+    Sum,

Review Comment:
   This is a more specific subset of GreaterEqual, I think it's nicer to add 
this variant and change cardinality_effect for the two physical plan nodes, 
rather than matching on those nodes specifically which seems like a leaky 
abstraction.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to