mbutrovich commented on code in PR #4128:
URL: https://github.com/apache/datafusion-comet/pull/4128#discussion_r3155705222
##########
spark/src/main/scala/org/apache/spark/sql/comet/CometIcebergNativeScanExec.scala:
##########
@@ -272,7 +273,8 @@ case class CometIcebergNativeScanExec(
override lazy val metrics: Map[String, SQLMetric] = {
val baseMetrics = Map(
- "output_rows" -> SQLMetrics.createMetric(sparkContext, "number of output
rows"))
+ "output_rows" -> SQLMetrics.createMetric(sparkContext, "number of output
rows"),
+ "bytes_scanned" -> SQLMetrics.createSizeMetric(sparkContext, "number of
bytes scanned"))
Review Comment:
The docstring ended up wrong in iceberg-rust. It includes data files and
delete files. I'll fix it upstream, but in the meantime this description is
accurate for Comet. I will also mention it in the Iceberg user guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
