comphead commented on code in PR #4128:
URL: https://github.com/apache/datafusion-comet/pull/4128#discussion_r3155670363
##########
native/core/src/execution/operators/iceberg_scan.rs:
##########
@@ -233,13 +239,16 @@ struct IcebergScanMetrics {
baseline: BaselineMetrics,
/// Count of file splits (FileScanTasks) processed
num_splits: Count,
+ /// Total bytes read from storage
+ bytes_scanned: Count,
}
impl IcebergScanMetrics {
fn new(metrics: &ExecutionPlanMetricsSet) -> Self {
Self {
baseline: BaselineMetrics::new(metrics, 0),
num_splits: MetricBuilder::new(metrics).counter("num_splits", 0),
+ bytes_scanned:
MetricBuilder::new(metrics).counter("bytes_scanned", 0),
Review Comment:
so for every new metric we need to create new `MetricBuider`. 🤔
DF actually expects this
```
/// Consumes self and creates a new [`Count`] for recording some
/// arbitrary metric of an operator.
pub fn counter
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
