Druva-D commented on code in PR #20268:
URL: https://github.com/apache/datafusion/pull/20268#discussion_r3154322671
##########
datafusion/spark/src/function/string/format_string.rs:
##########
@@ -2332,6 +2381,24 @@ impl FloatBits for f64 {
}
}
+/// Inserts thousands separators (`,`) into the integer part of a numeric
string.
+/// For example, `"1234567.89"` becomes `"1,234,567.89"`.
+fn insert_thousands_separator(number: &str) -> String {
Review Comment:
Will deduplicate and move it to ConversionSpecifier
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
